Exclude sqlalchemy-spanner 1.12.0 from core#51390
Closed
amoghrajesh wants to merge 1 commit intoapache:mainfrom
Closed
Exclude sqlalchemy-spanner 1.12.0 from core#51390amoghrajesh wants to merge 1 commit intoapache:mainfrom
amoghrajesh wants to merge 1 commit intoapache:mainfrom
Conversation
Contributor
Lee-W
approved these changes
Jun 4, 2025
Member
|
is it also used in core 🤔 yep, looks like it's handled in #51379 |
Contributor
Author
|
@eladkal that PR fixes it for google only |
Contributor
core doesn't need spanner. It makes no sense to exclude it in core. |
Contributor
Author
|
Looks like it hasnt been fixed properly in google |
Contributor
|
Should be closed in favor of #51393 |
Member
|
#51393 has now more detailed error description explaining where and where to fix similar problem when it happens next time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

https://github.com/apache/airflow/pull/51379/files was done but that seems to have fixed it for google but seems that the core is pulling in with this dependency leading to conflicts!
Error:
Example: https://github.com/apache/airflow/actions/runs/15433020002/job/43434553777
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.